Re: [PATCH V3 00/16] Introduce the BFQ I/O scheduler

From: Paolo Valente
Date: Wed Apr 12 2017 - 12:08:14 EST



> Il giorno 12 apr 2017, alle ore 17:30, Bart Van Assche <Bart.VanAssche@xxxxxxxxxxx> ha scritto:
>
> On Wed, 2017-04-12 at 08:01 +0200, Paolo Valente wrote:
>> Where is my mistake?
>
> I think in the Makefile. How about the patch below? Please note that I'm no
> Kbuild expert.
>

Thank you very much for finding and fixing the bug. I was working
exactly on that, and had got to the same solution (which I guess is
the only correct one). I'll apply these changes and resubmit.

Thanks,
Paolo

> diff --git a/block/Makefile b/block/Makefile
> index 546066ee7fa6..b3711af6b637 100644
> --- a/block/Makefile
> +++ b/block/Makefile
> @@ -20,7 +20,8 @@ obj-$(CONFIG_IOSCHED_NOOP) += noop-iosched.o
> obj-$(CONFIG_IOSCHED_DEADLINE) += deadline-iosched.o
> obj-$(CONFIG_IOSCHED_CFQ) += cfq-iosched.o
> obj-$(CONFIG_MQ_IOSCHED_DEADLINE) += mq-deadline.o
> -obj-$(CONFIG_IOSCHED_BFQ) += bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
> +bfq-y := bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
> +obj-$(CONFIG_IOSCHED_BFQ) += bfq.o
> obj-$(CONFIG_BLOCK_COMPAT) += compat_ioctl.o
> obj-$(CONFIG_BLK_CMDLINE_PARSER) += cmdline-parser.o
>