Re: [PATCH v2] scsi/bfa: use designated initializers

From: Kees Cook
Date: Wed Apr 12 2017 - 20:21:27 EST


On Thu, Mar 30, 2017 at 1:18 AM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Wed, Mar 29, 2017 at 01:55:09PM -0700, Kees Cook wrote:
>> Prepare to mark sensitive kernel structures for randomization by making
>> sure they're using designated initializers. These were identified during
>> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
>> extracted from grsecurity.
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> ---
>> This has been updated now that struct bfa_fcs_mod_s was dropped.
>
> Can you also add designated array initializers for __port_action while
> you're at it?

Hrm? This is what the patch already does. It adds them for both
__port_action and struct bfa_module_s.

-Kees

--
Kees Cook
Pixel Security