Re: [PATCH] block: bios with an offset are always gappy
From: Johannes Thumshirn
Date: Thu Apr 13 2017 - 06:01:51 EST
On Thu, Apr 13, 2017 at 11:48:35AM +0200, Christoph Hellwig wrote:
> On Thu, Apr 13, 2017 at 10:06:29AM +0200, Johannes Thumshirn wrote:
> > Doing a mkfs.btrfs on a (qemu emulated) PCIe NVMe causes a kernel panic
> > in nvme_setup_prps() because the dma_len will drop below zero but the
> > length not.
>
> I think we should also turns this into a WARN_ON_ONCE + error return..
>
> But do you have an exact btrfsprogs version and command line? I do a lot
> of testing that involves mkfs.btrfs on nvme and haven't seen it..
Ah one detail I forgot: mkfs.xfs _does_ work. Haven't checked ext4 though.
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850