RE: [PATCH] scsi: storvsc: remove return at end of void function

From: KY Srinivasan
Date: Thu Apr 13 2017 - 19:29:04 EST




> -----Original Message-----
> From: Miguel Bernal Marin [mailto:miguel.bernal.marin@xxxxxxxxxxxxxxx]
> Sent: Thursday, March 16, 2017 12:00 AM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Martin K. Petersen
> <martin.petersen@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>;
> Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>; James E.J. Bottomley
> <jejb@xxxxxxxxxxxxxxxxxx>
> Subject: [PATCH] scsi: storvsc: remove return at end of void function
>
> storvsc_on_channel_callback is a void function and the return
> statement at the end is not useful.
>
> Found with checkpatch.
>
> Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@xxxxxxxxxxxxxxx>

Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>

> ---
> drivers/scsi/storvsc_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3d70d1cf49a3..538f3e131275 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void
> *context)
> break;
> }
> } while (1);
> -
> - return;
> }
>
> static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
> --
> 2.12.0