Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

[Guenter Roeck]

On 04/13/2017 03:53 PM, Moritz Fischer wrote:
> Hi Guenter,
>
> On Thu, Apr 13, 2017 at 2:03 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > On Fri, Apr 07, 2017 at 03:00:08PM -0700, Moritz Fischer wrote:
> > > From: Moritz Fischer <mdf@xxxxxxxxxx>
> > >
> > > The ChromeOS EC has mapped memory regions where things like temperature
> > > sensors and fan speed are stored. Provide access to those from the
> > > cros-ec mfd device.
> >
> > Turns out struct cros_ec_device already provides a cmd_readmem callback,
> > which is widely used by other drivers. Why don't you just use it ?
>
> This is only actually set by the lpc version of the cros_ec. I2C and
> SPI connected ECs

Hmm - weird. I thought I saw it implemented for those, but I must have been
struck by lightning or something. Let me check with Gwendal to see how
this (ie its use from iio) is supposed to work on non-LPC systems.

Guenter

> emulate it. I can most certainly hook it up in the (spi,i2c) drivers,
> but the implementation
> for SPI and I2C needs to live somewhere. drivers/platform/chrome/cros_ec_proto.c
> seemed to be a good place.
>
> Thanks for the feedback!
>
> Moritz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html