Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all
From: Greg KH
Date: Fri Apr 14 2017 - 08:32:54 EST
On Fri, Apr 14, 2017 at 11:46:07AM +0200, Vincent Legoll wrote:
> Hello,
>
> >> No need to get into the submenu to disable all ANDROID-related config entries
> >
> > I don't understand this, what exactly do you mean?
>
> This is intended for people using make menuconfig to tailor
> their kernel config to their need by disabling all options they
> don't need. In order to have a smaller kernel, for example,
> but also to get smaller build times.
That's fine, but you aren't actually changing the functionality of any
of the build options here. You are just adding a 'menu' and showing
things a bit differently. You aren't changing any dependancies (which
is what dictates what is and is not built), which does not make it
easier, or harder, to disable/enable anything here.
I'm not against this, but you need to explain it a lot better as to what
you are doing and why. The "why" isn't covered by the "this will make
the kernel build smaller", as that's just not true :)
thanks,
greg k-h