Re: [PATCH 03/22] libiscsi: Make use of new the sg_map helper function

From: Logan Gunthorpe
Date: Fri Apr 14 2017 - 11:37:51 EST




On 14/04/17 02:36 AM, Christoph Hellwig wrote:
> On Thu, Apr 13, 2017 at 04:05:16PM -0600, Logan Gunthorpe wrote:
>> Convert the kmap and kmap_atomic uses to the sg_map function. We now
>> store the flags for the kmap instead of a boolean to indicate
>> atomicitiy. We also propogate a possible kmap error down and create
>> a new ISCSI_TCP_INTERNAL_ERR error type for this.
>
> Can you split out the new error handling into a separate prep patch
> which should go to the iscsi maintainers ASAP?
>

Yes, I can do that. I'd just have thought they'd want to see the use
case for the new error before accepting a patch like that...

Logan