Re: [PATCH V2] PM / OPP: Use - instead of @ for DT entries

From: Rafael J. Wysocki
Date: Mon Apr 17 2017 - 12:46:17 EST


On Monday, April 17, 2017 06:35:25 PM Rafael J. Wysocki wrote:
> On Monday, April 17, 2017 11:07:51 AM Masahiro Yamada wrote:
> > 2017-04-15 7:47 GMT+09:00 Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>:
> > > On Monday, April 10, 2017 02:51:35 PM Viresh Kumar wrote:
> > >> Compiling the DT file with W=1, DTC warns like follows:
> > >>
> > >> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> > >> unit name, but no reg property
> > >>
> > >> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > >> "reg" property.
> > >>
> > >> Reported-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > >> Reported-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > >> Suggested-by: Mark Rutland <mark.rutland@xxxxxxx>
> > >> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > >> Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> (sunxi)
> > >> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > >> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > >
> > > OK, so any ACKs from the DT side? Rob?
> > >
> > > Thanks,
> > > Rafael
> >
> >
> >
> > I see Rob's Acked-by.
> >
> > https://lkml.org/lkml/2017/4/13/648
>
> Indeed. Thanks!

But it doesn't apply on top of -rc7 for me, so I guess there is new 4.12-candidate
material in the DTS tree that conflicts with this, in which case it is better to route
it through the DTS tree IMO.

Thanks,
Rafael