Re: [PATCH] staging : rtl8188eu : remove void function return
From: Joe Perches
Date: Tue Apr 18 2017 - 08:03:20 EST
On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote:
> On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> > kernel coding style doesn't allow the return statement
> > in void function.
> >
> > Signed-off-by: surenderpolsani <surenderpolsani@xxxxxxxxx>
>
> I need a "real" name here, and in the from line please. Use what you
> use to sign documents.
You'll also need a patch that compiles properly.
void foo(void)
{
goto bar;
bar:
}
doesn't compile with gcc.
This patch removes the required statement after the
label immediately before the function end.
It could be replaced by just a semicolon which is
done a few places in the kernel or just left as-is.