Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module

From: Mark Brown
Date: Tue Apr 18 2017 - 11:18:56 EST


On Tue, Apr 18, 2017 at 12:59:54PM +0200, Lubomir Rintel wrote:
> It makes not sense: the whether the PIO PCM extension is used is
> hardcoded to the designware_i2s driver and designware_pcm doesn't
> have any module metadata, causing a kernel taint:
>
> [ 44.287000] designware_pcm: module license 'unspecified' taints kernel.
>
> Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>

This is not a a good approach, there is no technical reason to force the
driver to be built in. If you need a license tag in the module then add
that.

Attachment: signature.asc
Description: PGP signature