Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues

From: greg@xxxxxxxxx
Date: Tue Apr 18 2017 - 11:50:34 EST


On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
> Parantheses are added for Macro argument, to avoid precedence issues.
>
> Signed-off-by: Rishiraj Manwatkar <manwatkar@xxxxxxxxxxx>
> ---
> v1 -> v2: Added mailing list in cc.
> v2 -> v3: Changed From: to be same as Signed-off-by:.
> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
> */
>
> #define cl_io_for_each(slice, io) \
> - list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> + list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)

Really? There is no precedence issues that I can see here, sorry.

thanks,

greg k-h