Re: [PATCH] platform: x86: intel-hid: Add missing ->thaw callback

[Alex Hung]

On Tue, Apr 18, 2017 at 9:07 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Tue, Apr 18, 2017 at 03:49:06PM +0200, Rafael Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>
>> The intel-hid driver is missing a PM ->thaw callback allowing the
>> device to go back to the operational state after creating a
>> hibernation image or when there is an image restoration error during
>> resume.
>>
>> The lack of the ->thaw callback basically means that all events
>> signaled by the device are discarded after a hibernation image has
>> been created which may be problematic, for example, if the image
>> cannot be saved (eg. due to an I/O issue with storage).
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> + Alex Hung <alex.hung@xxxxxxxxxxxxx>
>
> Queued to testing, thank you Rafael.

Thank you Rafael for catching this.

>
>> ---
>>  drivers/platform/x86/intel-hid.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> Index: linux-pm/drivers/platform/x86/intel-hid.c
>> ===================================================================
>> --- linux-pm.orig/drivers/platform/x86/intel-hid.c
>> +++ linux-pm/drivers/platform/x86/intel-hid.c
>> @@ -136,6 +136,7 @@ static int intel_hid_pl_resume_handler(s
>>
>>  static const struct dev_pm_ops intel_hid_pl_pm_ops = {
>>       .freeze  = intel_hid_pl_suspend_handler,
>> +     .thaw  = intel_hid_pl_resume_handler,
>>       .restore  = intel_hid_pl_resume_handler,
>>       .suspend  = intel_hid_pl_suspend_handler,
>>       .resume  = intel_hid_pl_resume_handler,
>>
>>
>
> --
> Darren Hart
> VMware Open Source Technology Center



-- 
Cheers,
Alex Hung