Re: [PATCH 4/4] regulator: Add ROHM BD9571MWV-M PMIC regulator driver

[Mark Brown]

On Sun, Apr 16, 2017 at 08:08:01PM +0200, Marek Vasut wrote:

This looks good, a couple of minor things though:

> +static int bd9571mwv_regulator_is_enabled(struct regulator_dev *reg)
> +{
> +	/* Always enabled. */
> +	return 1;
> +}

This should be the default implementation, no need to open code it.

> +int bd9571mwv_set_voltage_sel_regmap(struct regulator_dev *rdev,
> +				     unsigned int sel)
> +{
> +	return regmap_write_bits(rdev->regmap, BD9571MWV_DVFS_SETVID,
> +				 rdev->desc->vsel_mask, sel);
> +}

regulator_set_voltage_sel_regmap().

Attachment: signature.asc
Description: PGP signature