Re: [PATCH V4] x86: call smp vmxoff in smp stop

From: Ingo Molnar
Date: Wed Apr 19 2017 - 04:04:10 EST



* Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:

> Ingo, can you put this in tip?
>
> Thanks,
>
> Paolo
>
> On 18/01/2017 12:32, Xishi Qiu wrote:
> > From: Tiantian Feng <fengtiantian@xxxxxxxxxx>
> >
> > We need to disable VMX on all CPUs before stop cpu when OS panic,
> > otherwisewe risk hanging up the machine, because the CPU ignore INIT
> > signals when VMX is enabled. In kernel mainline this issue existence.

Yes, but the changelog is atrcious:

- title should describe the purpose, not the implementation

- CPU is spelled 'CPU' once, then 'cpu' _in the same sentence_!

- typos

- spelling

- the last sentence doesn't even parse ...

Still it's already at V4 and comes with two signoffs and what amounts to a
maintainer Ack??

Thanks,

Ingo