Re: [RFC 2/2] mux: mmio-based syscon mux controller
From: Philipp Zabel
Date: Wed Apr 19 2017 - 07:50:22 EST
On Thu, 2017-04-13 at 18:09 -0700, Steve Longerbeam wrote:
>
> On 04/13/2017 08:48 AM, Philipp Zabel wrote:
> > This adds a driver for mmio-based syscon multiplexers controlled by a
> > single bitfield in a syscon register range.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > ---
> > drivers/mux/Kconfig | 13 +++++
> > drivers/mux/Makefile | 1 +
> > drivers/mux/mux-syscon.c | 130 +++++++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 144 insertions(+)
> > create mode 100644 drivers/mux/mux-syscon.c
> >
> > diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
> > index 86668b4d2fc52..a5e6a3b01ac24 100644
> > --- a/drivers/mux/Kconfig
> > +++ b/drivers/mux/Kconfig
> > @@ -43,4 +43,17 @@ config MUX_GPIO
> > To compile the driver as a module, choose M here: the module will
> > be called mux-gpio.
> >
> > +config MUX_SYSCON
>
> my preference would be CONFIG_MUX_MMIO.
>
> > + tristate "MMIO bitfield-controlled Multiplexer"
>
> "MMIO register bitfield-controlled Multiplexer"
>
> The rest looks good to me.
I'll change those. mux-syscon.c should probably be renamed to
mux-mmio.c, too.
regards
Philipp