Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module

From: Lubomir Rintel
Date: Wed Apr 19 2017 - 12:14:53 EST


On Wed, 2017-04-19 at 17:12 +0100, Jose Abreu wrote:
> Hi Lubomir,
>
>
> On 18-04-2017 18:15, Mark Brown wrote:
> > On Tue, Apr 18, 2017 at 06:13:30PM +0200, Lubomir Rintel wrote:
> >
> > > I don't think designware_pcm is a separate driver. It looks
> > > tightly
> > > coupled with designware_i2s: you can either disable
> > > designware_pcm
> > > altogether at build time or always load it together with
> > > designware_i2s.
> >
> > Yes, they're closely coupled but we might still want them both as a
> > module.
>
> Thanks for the patch but I agree with Mark.
>
> For the record you can add "MODULE_LICENSE(âDual MIT/GPLâ)".

Sorry if I'm missing something; but I still fail to understand why is
that a good idea.

What is the point of having a pair of modules that depend on each other
and can only be loaded together?

> Best regards,
> Jose Miguel Abreu

Lubo