Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode

[Andy Shevchenko]

On Fri, Apr 14, 2017 at 2:07 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> On Thu, Apr 13, 2017 at 10:09:43PM +0200, Carlo Caione wrote:
>> On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
>> > On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote:

> EINVAL is being used to broadly here. If the input values are incorrect, then
> yes -EINVAL is the right response. However, if the query was unsuccessful, that
> is more appropriately -EIO.
>
> If the handle/method doesn't exist, that would be -ENXIO.
>
> However, your changes make the driver self-consistent and I'll apply them as is
> to testing.

Darren, if it's not yet in for-next, I would like Carlo to update his
patch 1. I think it's better if we not shadow negative error code from
the callee.

-- 
With Best Regards,
Andy Shevchenko