Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()

[Sergei Shtylyov]

On 04/19/2017 05:29 PM, Alexander Kochetkov wrote:

> The patch replace phy_start_aneg() with phy_start(). phy_start() call

   Replaces.

> phy_start_aneg() as a part of startup sequence and allow recover from
> error (PHY_HALTED) state.
>
> Also added call phy_stop() to arc_emac_remove() to stop PHY state machine

   To arc_emac_stop() maybe?

> when MAC is down.

> Signed-off-by: Alexander Kochetkov <al.kochet@xxxxxxxxx>
> ---
>  drivers/net/ethernet/arc/emac_main.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
> index abc9f2a..188676d 100644
> --- a/drivers/net/ethernet/arc/emac_main.c
> +++ b/drivers/net/ethernet/arc/emac_main.c
[...]
> @@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
>  	napi_disable(&priv->napi);
>  	netif_stop_queue(ndev);
>
> +	phy_stop(ndev->phydev);
> +
>  	/* Disable interrupts */
>  	arc_reg_clr(priv, R_ENABLE, RXINT_MASK | TXINT_MASK | ERR_MASK);

MBR, Sergei