Re: [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency

From: Laurent Pinchart
Date: Wed Apr 19 2017 - 16:20:46 EST


Hi Arnd,

Thank you for the patch.

On Wednesday 19 Apr 2017 19:59:17 Arnd Bergmann wrote:
> The panel driver gained support for backlight but fails to link now
> when that is disabled:
>
> drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function
> `panel_dpi_probe_of': panel-dpi.c:(.text.panel_dpi_probe_of+0xe8):
> undefined reference to `of_find_backlight_by_node'
>
> This adds a dependency like we have for the other panel drivers.

I believe the dependency should be made optional. DPI panels that don't need
backlight control should be supported by a kernel that has backlight support
compiled out. How about something like