Re: [PATCH] perf, tools: Fix display of data source snoop indication
From: Arnaldo Carvalho de Melo
Date: Wed Apr 19 2017 - 17:53:59 EST
Em Wed, Apr 19, 2017 at 12:53:37PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> perf mem report doesn't display the data source snoop indication correctly.
>
> In the kernel API the definition is
I fixed this already, prepending the lines starting with # with two
spaces, so that it doesn't vanishes one 3rd time 8-)
- Arnaldo
> but the table used by the perf tools exchanged Hit and Miss
>
> "None",
> "Miss",
> "Hit",
>
> Fix the table in perf.
>
> Cc: eranian@xxxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
> tools/perf/util/mem-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
> index 1d4ab53c60ca..865ba3c39284 100644
> --- a/tools/perf/util/mem-events.c
> +++ b/tools/perf/util/mem-events.c
> @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info)
> static const char * const snoop_access[] = {
> "N/A",
> "None",
> - "Miss",
> "Hit",
> + "Miss",
> "HitM",
> };
>
> --
> 2.9.3