Re: [PATCH V3] PM / OPP: Use - instead of @ for DT entries
From: Rafael J. Wysocki
Date: Wed Apr 19 2017 - 18:12:30 EST
On Wednesday, April 19, 2017 07:22:15 AM Olof Johansson wrote:
> Hi Viresh,
>
> On Tue, Apr 18, 2017 at 10:44:50AM +0530, Viresh Kumar wrote:
> > Compiling the DT file with W=1, DTC warns like follows:
> >
> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> > unit name, but no reg property
> >
> > Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > "reg" property.
> >
> > Reported-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > Reported-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > Suggested-by: Mark Rutland <mark.rutland@xxxxxxx>
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> (sunxi)
> > Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> (uniphier)
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
>
> We've already turned down other patches that does this in a sweeping manner
> like this, since they tend to be conflict prone with other DT changes.
>
> Please split per platform and merge with each maintainer.
OK
So I'm assuming that you guys will take care of this going forward.
Thanks,
Rafael