Re: mwifiex: MAC randomization should not be persistent
From: Kalle Valo
Date: Thu Apr 20 2017 - 03:17:49 EST
Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> nl80211 provides the NL80211_SCAN_FLAG_RANDOM_ADDR for every scan
> request that should be randomized; the absence of such a flag means we
> should not randomize. However, mwifiex was stashing the latest
> randomization request and *always* using it for future scans, even those
> that didn't set the flag.
>
> Let's zero out the randomization info whenever we get a scan request
> without NL80211_SCAN_FLAG_RANDOM_ADDR. I'd prefer to remove
> priv->random_mac entirely (and plumb the randomization MAC properly
> through the call sequence), but the spaghetti is a little difficult to
> unravel here for me.
>
> Fixes: c2a8f0ff9c6c ("mwifiex: support random MAC address for scanning")
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.9+
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
Patch applied to wireless-drivers-next.git, thanks.
7e2f18f06408 mwifiex: MAC randomization should not be persistent
--
https://patchwork.kernel.org/patch/9665813/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches