Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions

[Luis Oliveira]

On 20-Apr-17 13:50, Jarkko Nikula wrote:
> On 04/12/2017 07:47 PM, Luis Oliveira wrote:
>> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
>> - Slave functions added to core library file
>> - Slave abort sources added to common source file
>> - New driver: i2c-designware-slave added
>> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>>   when supported by the architecture.
>>
>> All the SLAVE flow is added but it is not enabled via platform
>> driver.
>>
>> Signed-off-by: Luis Oliveira <lolivei@xxxxxxxxxxxx>
>> ---
>> v7-v8
>> - no changes
>>
>>  drivers/i2c/busses/Kconfig                 |  14 +-
>>  drivers/i2c/busses/Makefile                |   1 +
>>  drivers/i2c/busses/i2c-designware-common.c |   6 +
>>  drivers/i2c/busses/i2c-designware-core.h   |   2 +
>>  drivers/i2c/busses/i2c-designware-slave.c  | 403 +++++++++++++++++++++++++++++
>>  5 files changed, 425 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/i2c/busses/i2c-designware-slave.c
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 144cbadc7c72..84efa57f90b3 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -474,11 +474,23 @@ config I2C_DESIGNWARE_PLATFORM
>>      depends on (ACPI && COMMON_CLK) || !ACPI
>>      help
>>        If you say yes to this option, support will be included for the
>> -      Synopsys DesignWare I2C adapter. Only master mode is supported.
>> +      Synopsys DesignWare I2C adapter.
>>
>>        This driver can also be built as a module.  If so, the module
>>        will be called i2c-designware-platform.
>>
>> +config I2C_DESIGNWARE_SLAVE
>> +    bool "Synopsys DesignWare Slave"
>> +    select I2C_SLAVE
>> +    select I2C_SLAVE_EEPROM
> 
> I didn't notice this before - is there reason to select I2C_SLAVE_EEPROM?
> 
Yeah, this is in the wrong place. I need it to test it, but it shouldn't be
here. I will remove it.