Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11
From: Andy Lutomirski
Date: Thu Apr 20 2017 - 12:02:03 EST
On Wed, Apr 19, 2017 at 10:19 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Wed, Apr 19, 2017 at 09:52:17PM -0700, Andy Lutomirski wrote:
>> > I can make it so that force_apst=0 means no APST and force_apst=1 mean
>> > yes APST and we could try again with a quirk list for 4.12. There's a
>> > decent chance that a few more weeks with Ubuntu having APST on will
>> > shake out all the problems fairly quickly.
>>
>> Here's a more concrete and more sensible proposal:
>
> Can we just have force_apst=on to force it on, force_apst=off to turn
> it off, and leave it with that? And yes, I mean the strings instead
> of the weird numbers.
That's essentially what the patch I emailed here does -- it's a
regular bool param, so force_apst=1, force_apst=Y, and force_apst=y
all mean the same thing. I can just leave it like that.