Re: [PATCH v6 4/4] net: dsa: LAN9303: add MDIO managed mode support

[Rob Herring]

On Tue, Apr 18, 2017 at 10:48:27AM +0200, Juergen Borleis wrote:
> When the LAN9303 device is in MDIO manged mode, all register accesses must
> be done via MDIO.
> 
> Please note: this code is compile time tested only due to the absence of such
> configured hardware. It is based on a patch from Stefan Roese from 2014.
> 
> Signed-off-by: Juergen Borleis <jbe@xxxxxxxxxxxxxx>
> CC: devicetree@xxxxxxxxxxxxxxx
> CC: robh+dt@xxxxxxxxxx
> CC: mark.rutland@xxxxxxx
> CC: sr@xxxxxxx
> ---
>  .../devicetree/bindings/net/dsa/lan9303.txt        |  45 ++++++-

I'd prefer to see the full binding in one separate patch.

Otherwise, looks fine to me.

Acked-by: Rob Herring <robh@xxxxxxxxxx>

>  drivers/net/dsa/Kconfig                            |   8 ++
>  drivers/net/dsa/Makefile                           |   1 +
>  drivers/net/dsa/lan9303_mdio.c                     | 148 +++++++++++++++++++++
>  4 files changed, 201 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/net/dsa/lan9303_mdio.c