Re: [PATCH v4 1/1] pwm: pca9685: fix gpio-only operation.

From: Andy Shevchenko
Date: Thu Apr 20 2017 - 12:13:35 EST


On Thu, 2017-04-20 at 11:50 -0400, Sven Van Asbroeck wrote:
> > Thus, I would suggest: int sleep -> bool enable (or alike).
> >
> > Would we agree on that?
>
> I would. Perhaps also:
> set_sleep_mode(int sleep) -> enable_sleep_mode(bool enable) ?

I'm okay with a such (don't forget to change 0/1 in call sites to
false/true as well).

> Let's see what Mika and Thierry think.

I suppose Mika's answer is an acknowledge to the change.

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy