Re: [PATCH v2 0/2] nvme APST quirk updates, take two

[Andy Lutomirski]

On Thu, Apr 20, 2017 at 10:08 AM, Jens Axboe <axboe@xxxxxxxxx> wrote:
> On 04/20/2017 11:06 AM, Andy Lutomirski wrote:
>>
>>
>> On Apr 20, 2017 9:38 AM, "Jens Axboe" <axboe@xxxxxxxxx <mailto:axboe@xxxxxxxxx>> wrote:
>>
>>     On 04/20/2017 10:30 AM, Jens Axboe wrote:
>>     > On 04/20/2017 10:29 AM, Keith Busch wrote:
>>     >> On Thu, Apr 20, 2017 at 07:15:15PM +0300, Sagi Grimberg wrote:
>>     >>>
>>     >>>>> Hi Jens-
>>     >>>>>
>>     >>>>> These are just the quirk updates, split out.  The patches are
>>     >>>>> unchanged.
>>     >>>>>
>>     >>>>> I think that, even if we want to apply a broader quirk for 4.11, we
>>     >>>>> should still apply these so that we can cleanly revert the broader
>>     >>>>> quirk later.  IOW, let's get the known regressions fixed before we
>>     >>>>> get too excited about the unknown regressions.
>>     >>>>
>>     >>>> This looks good to me, and 4.11 appropriate. I'll expedite this
>>     >>>> through the block tree, if Keith/Sagi/Christoph agrees on this
>>     >>>> being the right approach for 4.11.
>>     >>>
>>     >>> I'm perfectly fine with this going to 4.11
>>     >>
>>     >> All good with me as well.
>>     >>
>>     >> Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx <mailto:keith.busch@xxxxxxxxx>>
>>     >
>>     > Great, I have queued it up.
>>
>>     Spoke too soon. Andy, did you compile this?
>>
>>     drivers/nvme/host/core.c: In function ânvme_init_identifyâ:
>>     drivers/nvme/host/core.c:1524:6: error: âforce_apstâ undeclared (first use in this function)
>>       if (force_apst && (ctrl->quirks & NVME_QUIRK_NO_DEEPEST_PS)) {
>>           ^~~~~~~~~~
>>     drivers/nvme/host/core.c:1524:6: note: each undeclared identifier is reported only once for each function it appears in
>>
>>     No, you did not.
>>
>>
>> I compiled the end result but not the middle.  D'oh.  Better version coming in an hour or two.
>
> This is from the end-result. I think you compiled the previous series,
> but not the revised v2 one you sent out. Because none of those patches
> add force_apst.

I was differently dumb.  I did git rebase -i and rearranged
everything, but I did git rebase --continue before running make, so I
tested the buggy patch with the patch that added force_apst on top.

Anyway, this time I'm going to compile, boot, and play with the exact
patches I send before I send them.  (Sadly, removing the debug patch
from the series has made this type of testing harder.  Oh well.)

--Andy