On Fri, Apr 14, 2017 at 8:29 PM,Will fix it in next version.
<sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>cove -> Cove
According to Whiskey cove PMIC spec, bit 7 of GPIOIRQ0_REG belongs to
Ditto.
battery IO. So we should skip this bit when checking for GPIO irq pendingirq -> IRQ
Ditto.
status. Otherwise, wcove_gpio_irq_handler() might go into the infiniteDitto.
loop until irq "pending" status becomes 0. This patch fixes this issue.
+#define GPIO_IRQ0_MASK 0x7fGENMASK()
+#define GPIO_IRQ1_MASK 0x3f
It comes to 84 characters. Should I leave it as it is ?
- pending = p[0] | (p[1] << 8);I would leave this on one line despite 80 characters limit (actually
+ pending = (p[0] & GPIO_IRQ0_MASK) |
+ ((p[1] & GPIO_IRQ1_MASK) << 7);
how long is it?).