Re: [PATCH v3] Staging: most: use __func__ instead of the function name

[Chandra Annamaneni]

Third Reminder. Please review.

--
Chandra


On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:

> 
> Second reminder, please review.
> 
> Thanks.
> Chandra
> 
> 
> On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@xxxxxxxxx>
> wrote:
> 
>       Change video.c to use %s, __func__ instead of function names.
>       Warnings flagged by checkpatch.pl
> 
>       Signed-off-by: Chandra Annamaneni <chandra627@xxxxxxxxx>
> 
>       diff --git a/drivers/staging/most/aim-v4l2/video.c
>       b/drivers/staging/most/aim-v4l2/video.c
>       index e074841..59e861e 100644
>       --- a/drivers/staging/most/aim-v4l2/video.c
>       +++ b/drivers/staging/most/aim-v4l2/video.c
>       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
>       Â Â Â Â struct most_video_dev *mdev = video_drvdata(filp);
>       Â Â Â Â struct aim_fh *fh;
> 
>       -Â Â Â Âv4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
>       +Â Â Â Âv4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>       Â Â Â Â switch (vdev->vfl_type) {
>       Â Â Â Â case VFL_TYPE_GRABBER:
>       @@ -128,7 +128,7 @@ static int aim_vdev_close(struct file *filp)
>       Â Â Â Â struct most_video_dev *mdev = fh->mdev;
>       Â Â Â Â struct mbo *mbo, *tmp;
> 
>       -Â Â Â Âv4l2_info(&mdev->v4l2_dev, "aim_vdev_close()\n");
>       +Â Â Â Âv4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>       Â Â Â Â /*
>       Â Â Â Â Â* We need to put MBOs back before we call
>       most_stop_channel()
>       @@ -324,7 +324,7 @@ static int vidioc_g_std(struct file *file,
>       void *priv, v4l2_std_id *norm)
>       Â Â Â Â struct aim_fh *fh = priv;
>       Â Â Â Â struct most_video_dev *mdev = fh->mdev;
> 
>       -Â Â Â Âv4l2_info(&mdev->v4l2_dev, "vidioc_g_std()\n");
>       +Â Â Â Âv4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>       Â Â Â Â *norm = V4L2_STD_UNKNOWN;
>       Â Â Â Â return 0;
>       @@ -361,7 +361,7 @@ static int vidioc_s_input(struct file *file,
>       void *priv, unsigned int index)
>       Â Â Â Â struct aim_fh *fh = priv;
>       Â Â Â Â struct most_video_dev *mdev = fh->mdev;
> 
>       -Â Â Â Âv4l2_info(&mdev->v4l2_dev, "vidioc_s_input(%d)\n",
>       index);
>       +Â Â Â Âv4l2_info(&mdev->v4l2_dev, "%s(%d)\n", __func__, index);
> 
>       Â Â Â Â if (index >= V4L2_AIM_MAX_INPUT)
>       Â Â Â Â Â Â Â Â return -EINVAL;
>       @@ -441,7 +441,7 @@ static int aim_register_videodev(struct
>       most_video_dev *mdev)
>       Â{
>       Â Â Â Â int ret;
> 
>       -Â Â Â Âv4l2_info(&mdev->v4l2_dev, "aim_register_videodev()\n");
>       +Â Â Â Âv4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>       Â Â Â Â init_waitqueue_head(&mdev->wait_data);
> 
>       @@ -471,7 +471,7 @@ static int aim_register_videodev(struct
>       most_video_dev *mdev)
> 
>       Âstatic void aim_unregister_videodev(struct most_video_dev
>       *mdev)
>       Â{
>       -Â Â Â Âv4l2_info(&mdev->v4l2_dev,
>       "aim_unregister_videodev()\n");
>       +Â Â Â Âv4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
> 
>       Â Â Â Â video_unregister_device(mdev->vdev);
>       Â}
> 
> 
> 
>