Re: [PATCH] dmaengine: sun4i: fix invalid argument
From: Maxime Ripard
Date: Fri Apr 21 2017 - 04:25:31 EST
On Fri, Apr 21, 2017 at 10:06:10AM +0200, Mason wrote:
> The "pchans_used" field is an unsigned long array.
>
> for_each_clear_bit_from() expects an unsigned long pointer,
> not an array address.
>
> $ make C=2 drivers/dma/sun4i-dma.o
> CHECK drivers/dma/sun4i-dma.c
> drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types)
> drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p
> drivers/dma/sun4i-dma.c:241:9: got unsigned long ( *<noident> )[1]
The patch looks good...
> Signed-off-by: Mason <slash.tmp@xxxxxxx>
However this doesn't.
See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature