Re: [PATCH 05/28] drm/bridge: fix include notation and remove -Iinclude/drm flag

[Masahiro Yamada]

2017-04-21 14:51 GMT+09:00 Andrzej Hajda <a.hajda@xxxxxxxxxxx>:
> Hi Masahiro,
>
> On 20.04.2017 11:56, Masahiro Yamada wrote:
>> Include <drm/*.h> instead of relative path from include/drm, then
>> remove the -Iinclude/drm compiler flag.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>> ---
>>
>>  drivers/gpu/drm/bridge/Makefile        |  2 --
>>  drivers/gpu/drm/bridge/nxp-ptn3460.c   | 10 +++++-----
>>  drivers/gpu/drm/bridge/parade-ps8622.c |  8 ++++----
>>  3 files changed, 9 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
>> index 3fe2226..defcf1e 100644
>> --- a/drivers/gpu/drm/bridge/Makefile
>> +++ b/drivers/gpu/drm/bridge/Makefile
>> @@ -1,5 +1,3 @@
>> -ccflags-y := -Iinclude/drm
>> -
>>  obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
>>  obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
>>  obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o
>> diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c
>> index 3517043..3fc285a 100644
>> --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c
>> +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c
>> @@ -24,11 +24,11 @@
>>  #include <drm/drm_of.h>
>>  #include <drm/drm_panel.h>
>>
>> -#include "drm_crtc.h"
>> -#include "drm_crtc_helper.h"
>> -#include "drm_atomic_helper.h"
>> -#include "drm_edid.h"
>> -#include "drmP.h"
>> +#include <drm/drm_crtc.h>
>> +#include <drm/drm_crtc_helper.h>
>> +#include <drm/drm_atomic_helper.h>
>> +#include <drm/drm_edid.h>
>> +#include <drm/drmP.h>
>
> Could you merge these includes with the ones above and sort them
> alphabetically.
>
>>
>>  #define PTN3460_EDID_ADDR                    0x0
>>  #define PTN3460_EDID_EMULATION_ADDR          0x84
>> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
>> index 1dcec3b..ada2186 100644
>> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
>> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
>> @@ -28,10 +28,10 @@
>>  #include <drm/drm_of.h>
>>  #include <drm/drm_panel.h>
>>
>> -#include "drmP.h"
>> -#include "drm_crtc.h"
>> -#include "drm_crtc_helper.h"
>> -#include "drm_atomic_helper.h"
>> +#include <drm/drmP.h>
>> +#include <drm/drm_crtc.h>
>> +#include <drm/drm_crtc_helper.h>
>> +#include <drm/drm_atomic_helper.h>
>
> Ditto.
>
> After this change you can add my:
> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
>

OK, I will wait for the maintainers' comments about
whether I need do this sort for whole of the series.




-- 
Best Regards
Masahiro Yamada