Re: [PATCH v3] Staging: most: use __func__ instead of the function name
From: Joe Perches
Date: Fri Apr 21 2017 - 06:31:10 EST
On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote:
> Third Reminder. Please review.
Patience.
> On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:
> > Second reminder, please review.
[]
> > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@xxxxxxxxx>
> > wrote:
> >
> > Change video.c to use %s, __func__ instead of function names.
> > Warnings flagged by checkpatch.pl
[]
> > diff --git a/drivers/staging/most/aim-v4l2/video.c
[]
> > @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> > struct most_video_dev *mdev = video_drvdata(filp);
> > struct aim_fh *fh;
> >
> > - v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> > + v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);
More likely all of these should be deleted
as these seem to be function tracing logging
and ftrace works well.
see: Documentation/trace/ftrace.txt