Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module

[Jose Abreu]

Hi,


On 20-04-2017 21:24, Takashi Iwai wrote:
> So, I think Lubomir's change is right.  But the patch subject and
> description should be rephrased.
>
> One thing I don't like is the rename of the file.  But in this
> particular case, it's unavoidable unless we rename the module name.
>

Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
called "dwc") and let the module still be called "designware-i2s"?

> BTW, we should drop the superfluous EXPORT_SYMBOL*(), too.
>
>
>

Lubomir, could you please remove the EXPORT_SYMBOL, change the
commit message and resend?

Best regards,
Jose Miguel Abreu