Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk
From: Josh Triplett
Date: Fri Apr 21 2017 - 14:47:50 EST
On Sat, Apr 22, 2017 at 10:17:11AM -0700, priyalee.kushwaha@xxxxxxxxx wrote:
> From: Priyalee Kushwaha <priyalee.kushwaha@xxxxxxxxx>
>
> Most OS distribution have awk in /usr/bin not in /bin
> Without this patch, kernel-devsrc fails to build as
> runtime dependency for srcu-cbmc script /bin/awk is
> not found.
>
> Signed-off-by: Kushwaha, Priyalee <priyalee.kushwaha@xxxxxxxxx>
For anyone that has it in /bin/awk, does it have a compatibility symlink
from /usr/bin/awk (or vice versa), or not? If not, then this would
break the build for those folks.
We could just drop the shebang and the executable bit, and run "awk -f
modify_srcu.awk" from whatever script invokes this.
> tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> index 8ff8904..c9e8bc5 100755
> --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/modify_srcu.awk
> @@ -1,4 +1,4 @@
> -#!/bin/awk -f
> +#!/usr/bin/awk -f
>
> # Modify SRCU for formal verification. The first argument should be srcu.h and
> # the second should be srcu.c. Outputs modified srcu.h and srcu.c into the
> --
> 2.10.0
>