Re: [PATCH 2/5] lightnvm: pblk: fix bad error check

From: Matias BjÃrling
Date: Sat Apr 22 2017 - 04:53:32 EST


On 04/22/2017 01:32 AM, Javier GonzÃlez wrote:
Fix bad error check

Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target"

Signed-off-by: Javier GonzÃlez <javier@xxxxxxxxxxxx>
---
drivers/lightnvm/pblk-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 7065658..7eb62ec 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1273,7 +1273,7 @@ struct pblk_line *pblk_line_replace_data(struct pblk *pblk)
retry_setup:
if (!pblk_line_set_metadata(pblk, new, cur)) {
new = pblk_line_retry(pblk, new);
- if (new)
+ if (!new)
return NULL;

goto retry_setup;


Reviewed-by: Matias BjÃrling <matias@xxxxxxxxxxxx>