Re: [PATCH v2 03/11] dt-bindings: soc/fsl: Update reserved memory binding for QBMan

[Scott Wood]

On Wed, 2017-04-19 at 16:48 -0400, Roy Pledge wrote:
> Updates the QMan and BMan device tree bindings for reserved memory
> nodes. This makes the reserved memory allocation compatiable with
> the shared-dma-pool usage.
> 
> Signed-off-by: Roy Pledge <roy.pledge@xxxxxxx>
> ---
> ÂDocumentation/devicetree/bindings/soc/fsl/bman.txt | 11 ++++++-----
> ÂDocumentation/devicetree/bindings/soc/fsl/qman.txt | 18 +++++++++++-------
> Â2 files changed, 17 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/fsl/bman.txt
> b/Documentation/devicetree/bindings/soc/fsl/bman.txt
> index 47ac834..3cd1e2c 100644
> --- a/Documentation/devicetree/bindings/soc/fsl/bman.txt
> +++ b/Documentation/devicetree/bindings/soc/fsl/bman.txt
> @@ -65,8 +65,8 @@ to the respective BMan instance
> ÂBMan Private Memory Node
> Â
> ÂBMan requires a contiguous range of physical memory used for the backing
> store
> -for BMan Free Buffer Proxy Records (FBPR). This memory is
> reserved/allocated as a
> -node under the /reserved-memory node
> +for BMan Free Buffer Proxy Records (FBPR). This memory is
> reserved/allocated as
> +a node under the /reserved-memory node.
> Â
> ÂThe BMan FBPR memory node must be named "bman-fbpr"
> Â
> @@ -75,7 +75,8 @@ PROPERTIES
> Â- compatible
> Â	Usage:		required
> Â	Value type:	<stringlist>
> -	Definition:	Must inclide "fsl,bman-fbpr"
> +	Definition:	PPC platforms: Must include "fsl,bman-fbpr"
> +			ARM platforms: Must include "shared-dma-pool"
> Â
> ÂThe following constraints are relevant to the FBPR private memory:
> Â	- The size must be 2^(size + 1), with size = 11..33. That is 4 KiB
> to
> @@ -100,10 +101,10 @@ The example below shows a BMan FBPR dynamic allocation
> memory node
> Â		ranges;
> Â
> Â		bman_fbpr: bman-fbpr {
> -			compatible = "fsl,bman-fbpr";
> -			alloc-ranges = <0 0 0x10 0>;
> +			compatible = "shared-mem-pool";
> Â			size = <0 0x1000000>;
> Â			alignment = <0 0x1000000>;
> +			no-map;
> Â		};
> Â	};
> Â

The requirement for using no-map with shared-mem-pool should be explicitly
stated, not just in the example.

-Scott