Re: [PATCH V5 3/7] ARM: exynos: Use - instead of @ for DT OPP entries

[Krzysztof Kozlowski]

On Mon, Apr 24, 2017 at 10:30 AM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 2017-04-21 1:09 GMT+09:00 Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>> On Thu, Apr 20, 2017 at 04:25:07PM +0530, Viresh Kumar wrote:
>>> Compiling the DT file with W=1, DTC warns like follows:
>>>
>>> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
>>> unit name, but no reg property
>>>
>>> Fix this by replacing '@' with '-' as the OPP nodes will never have a
>>> "reg" property.
>>>
>>> Reported-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>>> Reported-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>>> Suggested-by: Mark Rutland <mark.rutland@xxxxxxx>
>>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>>> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>>> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>>> ---
>>>  .../devicetree/bindings/devfreq/exynos-bus.txt     | 46 +++++++--------
>>>  arch/arm/boot/dts/exynos3250.dtsi                  | 46 +++++++--------
>>>  arch/arm/boot/dts/exynos4210.dtsi                  | 32 +++++------
>>>  arch/arm/boot/dts/exynos4412-prime.dtsi            |  4 +-
>>>  arch/arm/boot/dts/exynos4412.dtsi                  | 66 +++++++++++-----------
>>>  arch/arm/boot/dts/exynos5420.dtsi                  | 40 ++++++-------
>>>  arch/arm/boot/dts/exynos5800.dtsi                  | 56 +++++++++---------
>>>  arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi     | 48 ++++++++--------
>>>  arch/arm64/boot/dts/exynos/exynos5433.dtsi         | 50 ++++++++--------
>>>  9 files changed, 194 insertions(+), 194 deletions(-)
>>
>>
>> Thanks, split ARM64 from ARM and applied (for v4.12). arm-soc keeps DTS
>> separated between ARM architectures. Technically this should require a
>> resend but we had way too many resends for this simple patch.
>>
>
>
> Minor note:
>
> For arm64 part, Krzysztof's Signed-off-by is doubled.
> (commit 5dccc9873c4af60f4478b3ef54267353f25cc301)

Thanks for spotting it.

Best regards,
Krzysztof