Re: [PATCH] scsi: sas: move scsi_remove_host call into sas_remove_host

[Johannes Thumshirn]

On Mon, Apr 24, 2017 at 02:38:40PM +0100, John Garry wrote:
> On 24/04/2017 11:09, John Garry wrote:
> >On 21/04/2017 13:11, Johannes Thumshirn wrote:
> >>Move scsi_remove_host call into sas_remove_host and remove it from SAS
> >>HBA
> >>drivers, so we don't mess up the ordering. This solves an issue with
> >>double
> >>deleting sysfs entries that was introduced by the change of sysfs
> >>behaviour
> >>from commit bcdde7e ("sysfs: make __sysfs_remove_dir() recursive").
> >>
> >>Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> >>Suggested-by: Christoph Hellwig <hch@xxxxxx>
> >>Cc: Hannes Reinecke <hare@xxxxxxx>
> >>Cc: James Bottomley <jejb@xxxxxxxxxxxxxxxxxx>
> >>Cc: Jinpu Wang <jinpu.wang@xxxxxxxxxxxxxxxx>
> >>Cc: John Garry <john.garry@xxxxxxxxxx>
> >
> >For what it's worth:
> >
> >Tested-by: John Garry <john.garry@xxxxxxxxxx> # On hisi_sas
> >
> 
> I have actually tested this a little further and now I see an issue. Maybe
> it is related to the internal development kernel I am using or a
> pre-existing issue with our driver, but I doubt it.
> This time I removed the WARN in sysfs_remove_group() [so the console is not
> bombarded] and ran repeated insmod/rmmod, and I see this sometimes:

[...]


> Ring any bells? I don't see this new WARN without the change.

No haven't seen the WARN in my tests but I didn't do a insmod/rmmod stress
test anyways.

I'll have a look.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850