Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions

[Doug Ledford]

On Mon, 2017-04-24 at 08:54 -0400, Dennis Dalessandro wrote:
> On 04/23/2017 03:33 AM, Leon Romanovsky wrote:
> > 
> > On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote:
> > > 
> > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > > Date: Sat, 22 Apr 2017 13:26:49 +0200
> > > 
> > > Replace the specification of data types by pointer dereferences
> > > as the parameter for the operator "sizeof" to make the
> > > corresponding size
> > > determinations a bit safer according to the Linux coding style
> > > convention.
> > > 
> > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > > ---
> > > 
> > > v2:
> > > Changes were rebased on source files from Linux next-20170421.
> > > These were recombined as requested by Doug Ledford.
> > 
> > Hi Doug,
> > 
> > I recommend you to be extra cautious with this blind automatic
> > conversions. It requires inspection that every size before and
> > after
> > match each other.
> > 
> > I already asked it and would be like to repeat it. Please DON'T
> > take any
> > patches from Markus, which are related to mlx4/mlx5/rxe without our
> > explicit
> > review of them.
> 
> I agree with Leon here, and these sort of find/replace automagicÂ
> clean-up patches make me nervous sometimes.

OK, the easiest way to make sure that only the things you want from his
patches get through is to have you pull them into a branch and submit
them yourself.ÂÂI'll only take the ones you submit to me, that way
there is no confusion about whether or not you have checked them and
approved them.

> Markus, what have you done to ensure your patches don't break
> anything?
> 
> -Denny
> 
-- 
Doug Ledford <dledford@xxxxxxxxxx>
  GPG KeyID: B826A3330E572FDD
 Â
Key fingerprint = AE6B 1BDA 122B 23B4 265B Â1274 B826 A333 0E57 2FDD