Re: [PATCH] stmmac: Add support for SIMATIC IOT2000 platform

[Andy Shevchenko]

On Mon, Apr 24, 2017 at 10:27 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
> The IOT2000 is industrial controller platform, derived from the Intel
> Galileo Gen2 board. The variant IOT2020 comes with one LAN port, the
> IOT2040 has two of them. They can be told apart based on the board asset
> tag in the DMI table.
>
> Based on patch by Sascha Weisenberger.
>

> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> Signed-off-by: Sascha Weisenberger <sascha.weisenberger@xxxxxxxxxxx>

Shoudn't be ordered other way around?

> +       const char *asset_tag;

I guess this is redundant. See below.

> +       {
> +               .name = "SIMATIC IOT2000",
> +               .asset_tag = "6ES7647-0AA00-0YA2",
> +               .func = 6,
> +               .phy_addr = 1,
> +       },

The below has same definition disregard on asset_tag.

> +       {
> +               .name = "SIMATIC IOT2000",
> +               .asset_tag = "6ES7647-0AA00-1YA2",
> +               .func = 6,
> +               .phy_addr = 1,
> +       },
> +       {
> +               .name = "SIMATIC IOT2000",
> +               .asset_tag = "6ES7647-0AA00-1YA2",
> +               .func = 7,
> +               .phy_addr = 1,
> +       },

How this supposed to work if phy_addr is the same?

-- 
With Best Regards,
Andy Shevchenko