Re: [PATCH 20/22] tools arch: Sync arch/x86/lib/memcpy_64.S with the kernel

From: Joe Perches
Date: Mon Apr 24 2017 - 23:00:02 EST


On Mon, 2017-04-24 at 13:36 -0700, Luck, Tony wrote:
> On Mon, Apr 24, 2017 at 04:54:37PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> >
> > Just a minor fix done in:
> >
> > Fixes: 26a37ab319a2 ("x86/mce: Fix copy/paste error in exception table entries")
> >
> > Cc: Tony Luck <tony.luck@xxxxxxxxx>
> > Link: http://lkml.kernel.org/n/tip-ni9jzdd5yxlail6pq8cuexw2@xxxxxxxxxxxxxx
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> > ---
> > tools/arch/x86/lib/memcpy_64.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/arch/x86/lib/memcpy_64.S b/tools/arch/x86/lib/memcpy_64.S
> > index 49e6ebac7e73..98dcc112b363 100644
> > --- a/tools/arch/x86/lib/memcpy_64.S
> > +++ b/tools/arch/x86/lib/memcpy_64.S
> > @@ -286,7 +286,7 @@ ENDPROC(memcpy_mcsafe_unrolled)
> > _ASM_EXTABLE_FAULT(.L_copy_leading_bytes, .L_memcpy_mcsafe_fail)
> > _ASM_EXTABLE_FAULT(.L_cache_w0, .L_memcpy_mcsafe_fail)
> > _ASM_EXTABLE_FAULT(.L_cache_w1, .L_memcpy_mcsafe_fail)
> > - _ASM_EXTABLE_FAULT(.L_cache_w3, .L_memcpy_mcsafe_fail)
> > + _ASM_EXTABLE_FAULT(.L_cache_w2, .L_memcpy_mcsafe_fail)
> > _ASM_EXTABLE_FAULT(.L_cache_w3, .L_memcpy_mcsafe_fail)
> > _ASM_EXTABLE_FAULT(.L_cache_w4, .L_memcpy_mcsafe_fail)
> > _ASM_EXTABLE_FAULT(.L_cache_w5, .L_memcpy_mcsafe_fail)
>
> If we are going to have all these copies of kernel files below
> "tools/...", perhaps checkpatch could warn people touching one
> that the other needs the same update?

How would checkpatch know tools hasn't already updated the other?