Re: [PATCH] check for null while iterating over a scatterlist table

From: Christoph Hellwig
Date: Tue Apr 25 2017 - 03:42:29 EST

Next message: AZO: "[PATCH] drivers: input: joystick: Add PSX (Play Station 1/2) pad with SPI driver."
Previous message: Neil Armstrong: "[PATCH] media: rc: meson-ir: switch config to NEC decoding on shutdown"
In reply to: Rajnikant Bhojani: "[PATCH] check for null while iterating over a scatterlist table"
Next in thread: Rajnikant Bhojani: "[PATCH] check for null while iterating over a scatterlist table"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Apr 25, 2017 at 01:08:49PM +0530, Rajnikant Bhojani wrote:
> during iterating over a scatterlist table also need to check for NULL
> along with number of scatterlist

Not sure this is a good idea. Callers expect to iterate over the
full number in general. Exiting early just papers over the bug
instead of fixing it. A WARN_ON for this case might be a better idea.

Next message: AZO: "[PATCH] drivers: input: joystick: Add PSX (Play Station 1/2) pad with SPI driver."
Previous message: Neil Armstrong: "[PATCH] media: rc: meson-ir: switch config to NEC decoding on shutdown"
In reply to: Rajnikant Bhojani: "[PATCH] check for null while iterating over a scatterlist table"
Next in thread: Rajnikant Bhojani: "[PATCH] check for null while iterating over a scatterlist table"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]