Re: [PATCH] x86, msr: Better document AMD "tweak MSRs", rename MSR_F15H_IC_CFG

From: Borislav Petkov
Date: Tue Apr 25 2017 - 08:00:15 EST


On Tue, Apr 25, 2017 at 01:45:41PM +0200, Denys Vlasenko wrote:
> Before this patch, we have a define for MSR 0xc0011021: MSR_F15H_IC_CFG.
> But it exists starting from K8, so it's not really a Fam15h MSR only.
>
> Lat's call it MSR_AMD64_IC_CFG.

Except that we name only those MSRs with "AMD64" which are
architectural. See "Appendix A MSR Cross-Reference" in APM vol 2.

And the ones you want to rename are not and there is no guarantee about
anything wrt to those. So no, I'd prefer if those remained per-family as
it is now.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.