Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities
From: Tejun Heo
Date: Tue Apr 25 2017 - 17:10:11 EST
On Mon, Apr 24, 2017 at 02:35:28PM -0700, Tejun Heo wrote:
> Now that a cfs_rq sched_entity's load_avg always gets propagated from
> the associated cfs_rq, there's no point in calling __update_load_avg()
> on it. The two mechanisms compete with each other and we'd be always
> using a value close to the propagated one anyway.
>
> Skip __update_load_avg() for cfs_rq sched_entities. Also, relocate
> propagate_entity_load_avg() to signify that propagation is the
> counterpart to __update_load_avg() for cfs_rq sched_entities. This
> puts the propagation before update_cfs_rq_load_avg() which shouldn't
> disturb anything.
Please ignore this patch. As we don't propagate on decays, we still
need __update_load_avg() on runanble_load_avg so that it can decay on
its own.
Thanks.
--
tejun