Re: [PATCH] scsi: stex: make S6flag static

From: Charles Chiou
Date: Tue Apr 25 2017 - 22:41:17 EST


Looks good to me.
Thanks for the improvement.

On 4/26/2017 1:36 AM, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

This module specific flag can be made static as it does
not need to be in global scope.

> Reviewed-by: Charles Chiou <charles.chiou@xxxxxxxxxxxxxx>
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/scsi/stex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 0751561b59da..9b20643ab49d 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -363,7 +363,7 @@ struct st_card_info {
u16 sts_count;
};
-int S6flag;
+static int S6flag;
static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
static struct notifier_block stex_notifier = {
stex_halt, NULL, 0