Re: [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c
From: Tobin C. Harding
Date: Tue Apr 25 2017 - 23:21:13 EST
On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote:
> This is a patch to the ks_wlan_net.c file that fixes up the following warning
> found by the checkpatch.pl tool:
> WARNING: Block comments use a trailing */ on a separate line
Good work resubmitting this following Greg's comments. May I suggest
some ways to hasten your success.
Note firstly, that I appreciate that writing the gitlog message is
very difficult to do well. I am by no means an expert.
- You don't need to mention the file, especially not in the subject. We
can see the files changed from the patch itself.
- You should refrain from using 'this patch', the subject (as in
subject, object, verb) is implicit.
See Documentation/process/submitting-patches.rst (Section 2: Describe
your changes).
Example
Checkpatch emits WARNING: Block comments use a trailing */ on a
separate line.
Move trailing */ to separate line.
Good luck,
Tobin.