Re: [PATCH v4 2/4] zram: implement deduplication in zram

From: Joonsoo Kim
Date: Wed Apr 26 2017 - 02:02:30 EST


On Wed, Apr 26, 2017 at 11:37:18AM +0900, Sergey Senozhatsky wrote:
> On (04/26/17 09:52), js1304@xxxxxxxxx wrote:
> [..]
> > struct zram_entry {
> > + struct rb_node rb_node;
> > + u32 len;
> > + u32 checksum;
> > + unsigned long refcount;
>
> use refcount_t? what do you think?

We don't need atomic operation for refcount but refcount_t does.
API of refcount_t provides additional guarantee that refcount will not
overflow but I'm not sure that this overhead is needed here.

Thanks.