Re: [PATCH] memmap: Parse "Reserved" together with "reserved"

[Dave Young]

On 04/26/17 at 08:22am, Ingo Molnar wrote:
> 
> * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> 
> > For x86 with recent kernel after
> >  commit 640e1b38b0 ("x86/boot/e820: Basic cleanup of e820.c")
> > change "reserved" to "Reserved" in /sys firmware memmap and /proc/iomem.
> > 
> > So here, we add handling for that too.
> > 
> > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> > 
> > ---
> >  kexec/arch/i386/crashdump-x86.c |    2 ++
> >  kexec/arch/ia64/kexec-ia64.c    |    2 ++
> >  kexec/arch/mips/kexec-mips.c    |    2 ++
> >  kexec/firmware_memmap.c         |    2 ++
> >  4 files changed, 8 insertions(+)
> 
> I'd rather fix the bug I introduced and undo the reserved->Reserved string change 

This patch parses both 'reserved' and 'Reserved' it should be fine, but
reverting the change in kernel sounds better..

> in e820.c: I didn't realize that it's exposed in sysfs and had quasi-ABI 
> consequences for kexec.
> 
> Agreed?
> 
> Thanks,
> 
> 	Ingo
> 
> _______________________________________________
> kexec mailing list
> kexec@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/kexec

Thanks
Dave