Re: [PATCH 0/4] sched/topology: fix overlap group capacity and balance cpu

From: Lauro Venancio
Date: Wed Apr 26 2017 - 13:59:23 EST


On 04/26/2017 01:31 PM, Peter Zijlstra wrote:
>
> Please have a look here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wip
>
> I think that has them all.
Yes. I agree.
>
> I'm still thinking on how to best create a test to assert on the SGC
> condition, but I don't seem to get much further than brute-force
> matching all group masks. At least we now display (albeit I don't like
> the format, suggestions?) the stuff.

I cannot think in anything other than brute-force, too.

Maybe, to make the debug messages clear, you could print "balance_cpu:
%d" instead of "capacity(%d): " and assert (sgc id == balance cpu). You
would need to restart the sgc id count on every topology level.