Re: [PATCH] iio: adc: Add support for TI ADC1x8s102

From: Jonathan Cameron
Date: Thu Apr 27 2017 - 02:04:56 EST


On 27/04/17 07:01, Jonathan Cameron wrote:
> On 26/04/17 10:01, Mika Westerberg wrote:
>> On Tue, Apr 25, 2017 at 06:12:12PM +0200, Jan Kiszka wrote:
>>> Now, do you also a suggestion where to put that 5 V reference voltage
>>> value that is hard-coded (via wiring) on the target boards for the ADC?
>>> That is now device-specific, not a controller parameter. Is there an
>>> ACPI-way to express such a parameter?
>>
>> You may put it into device property using _DSD (as long as you don't try
>> to represent regulators or so).
>>
>>> How would that be done for DTs?
>>
>> I don't know but you may look under Documentation/devicetree/bindings if
>> there is anything.
> Under DT it would be done using a fixed voltage regulator.
Though having actually looked at the driver, you presumably already know this
given you are requesting an appropriate regulator...
>>
>>> Plan B would be hard-coding in the code for now, waiting for a second,
>>> non-ACPI user to address it.
>>
>> Sounds reasonable.
> Somewhat of a pain to basically use a random value as the default going
> forward. Presumably this isn't the first ever ACPI table to need to
> tell use about a reference voltage...
>
> Mark, seen anything similar?
>
> I see https://www.kernel.org/doc/Documentation/arm64/arm-acpi.txt suggests
> that mapping to regulators isn't expected to ever happen...
>
> Jonathan
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>